Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update on alias ( minor ) #2215

Closed
wants to merge 5 commits into from
Closed

update on alias ( minor ) #2215

wants to merge 5 commits into from
+40 −13

Conversation

Doraken
Copy link

@Doraken Doraken commented Aug 16, 2023

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@bittner
Copy link
Contributor

bittner commented Oct 1, 2023

I think you need to provide a description and explain the motivation for the changes if you want this PR to get merged.

@cornfeedhobo
Copy link
Member

@Doraken I'm going to close this since you haven't replied and the code doesn't make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Doraken @bittner @cornfeedhobo